Open
Conversation
jp-tosca
added
GREI Re-arch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #12141 by moving Dataverse Storage Driver endpoints out of the Admin API namespace and exposing them under the Dataverses API.
Changes:
- Moved storage driver GET/PUT/DELETE endpoints from
/api/admin/dataverse/{alias}/storageDriverto/api/dataverses/{identifier}/storageDriver. - Replaced the former “list storage drivers” admin endpoint with a dataverse-scoped endpoint intended to list allowed drivers.
- Updated integration tests and admin docs/release notes to reflect the endpoint move.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java | Updates helper methods to call the new dataverses storage driver endpoints (but list path currently mismatches new API). |
| src/test/java/edu/harvard/iq/dataverse/api/S3AccessIT.java | Updates calls to the storage-driver listing helper to include a dataverse alias. |
| src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java | Updates storage-driver listing helper usage for dataset storage driver test. |
| src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SetDataverseStorageDriverCommand.java | New command to set a collection’s storage driver by label. |
| src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GetDataverseStorageDriverCommand.java | New command to fetch direct/effective storage driver id with release-based permission requirements. |
| src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GetDataverseAllowedStorageDriverCommand.java | New command to list drivers (currently returns all drivers; permission model may need alignment). |
| src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataverseStorageDriverComman.java | New command to reset a collection’s configured storage driver (class name contains a typo). |
| src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SetDataverseMetadataLanguageCommand.java | Removes an unused import. |
| src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java | Adds new /storageDriver and /allowedStorageDrivers endpoints under /api/dataverses/{identifier}; removes unrelated commented-out logo code; introduces unused imports. |
| src/main/java/edu/harvard/iq/dataverse/api/Admin.java | Removes the old admin storage driver endpoints. |
| src/main/java/edu/harvard/iq/dataverse/api/Info.java | Adds imports but currently leaves them unused (compile-breaking). |
| doc/sphinx-guides/source/admin/dataverses-datasets.rst | Updates curl examples to the new endpoint locations; superuser-only wording likely no longer matches implementation. |
| doc/release-notes/12141-storage-driver-endpoints.md | Adds release note for breaking endpoint changes; contains typos and path accuracy issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...in/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataverseStorageDriverComman.java
Outdated
Show resolved
Hide resolved
… command implementation for resetting storage driver
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: